Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps: update component spec interfaces #559

Merged
merged 2 commits into from
Sep 21, 2022
Merged

apps: update component spec interfaces #559

merged 2 commits into from
Sep 21, 2022

Conversation

kamaln7
Copy link
Contributor

@kamaln7 kamaln7 commented Sep 21, 2022

  • update interface AppBuildableComponentSpec to match functions components
  • add interfaces AppDockerBuildableComponentSpec and AppCNBBuildableComponentSpec
  • remove deprecated field/accessor GetEnvironmentSlug

@kamaln7
update app component spec interfaces
c8886a0 
* update interface AppBuildableComponentSpec to match functions components
* add interfaces AppDockerBuildableComponentSpec and AppCNBBuildableComponentSpec
@kamaln7
remove deprecated field/accessor GetEnvironmentSlug
db81e78
nicktate
nicktate approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@nicktate nicktate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new interface separation makes sense to me 👍

andrewsomething
andrewsomething approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewsomething andrewsomething merged commit 3c96e9f into digitalocean:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktate nicktate nicktate approved these changes

@andrewsomething andrewsomething andrewsomething approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamaln7 @andrewsomething @nicktate