[wip] ci improvements

Author: anitgandhi

.github/workflows/go.yml

@@ -11,55 +11,54 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
-
     - name: Set up Go
-      uses: actions/setup-go@v2
+      uses: actions/setup-go@v6
       with:
         go-version: 1.25
 
-    - name: OVS setup
+    - name: Set up OVS
       run: |
        sudo apt-get update
         sudo apt install openvswitch-switch
         sudo ovs-vsctl add-br ovsbr0
-        
-    - name: Check and test
-      run: |
-        export GOPATH=/home/runner/work
-        export PATH=$PATH:$GOPATH/bin
-        mkdir $GOPATH/src $GOPATH/pkg $GOPATH/bin
-        go install honnef.co/go/tools/cmd/[email protected]
-        NEW=$GOPATH/src/github.com/digitalocean/go-openvswitch
-        mkdir -p $NEW
-        cp -r ./* $NEW
-        cd $NEW
-        go mod download
-        go get golang.org/x/lint/golint
-        go get -d ./...
+
+    - uses: actions/checkout@v5
+
+    - name: License check
+      run: |     
         echo "=========START LICENSE CHECK============"
         ./scripts/licensecheck.sh
-        echo "=========START BUILD============"
-        go build -v -tags=gofuzz ./...
-        echo "=========START VET============"
+
+    - name: Download deps
+      run: go mod download
+  
+    - name: Lint
+      run: |
+        # install tools
+        go install honnef.co/go/tools/cmd/staticcheck@latest
+        go install golang.org/x/lint/golint@latest
+        go install github.com/praetorian-inc/gokart@latest
+
         go vet ./...
-        echo "=========START GO FMT CHECK============"
         ./scripts/gofmt.sh
-        echo "=========START GO LINT CHECK============"
+        # TODO: replace with revive
         ./scripts/golint.sh
-        echo "=========START STATICCHECK============"
-        staticcheck ./...
-        echo "=========START LINT============"
         golint -set_exit_status ./cmd/... ./internal/...
+        staticcheck ./...
+
+    - name: Run Gosec Security Scanner
+      uses: securego/gosec@master
+      with:
+        args: ./...
+
+    - name: Build
+      run: go build -v ./...
+        
+    - name: Test
+      run: |
         echo "=========START TESTS IN OVS============"
         go test -v -race -short ./ovs/
         echo "=========START TESTS IN OVSDB============"
-        go test -v -race ./ovsdb/
-        go test -c -race ./ovsdb
+        sudo go test -v -race ./ovsdb/
         echo "=========START TESTS IN OVSNL============"
         go test -v -race ./ovsnl/
-        echo "=========START OVSDB.TEST============"
-        sudo ./ovsdb.test -test.v
-        echo "=========START SECURITY SCANNING============"
-        go install github.com/praetorian-inc/gokart@latest
-        gokart scan

scripts/gofmt.sh

@@ -2,13 +2,10 @@
 
 # Verify that all files are correctly gofmt'd, with the exception of
 # generated code.
-EXIT=0
-GOFMT=$(go fmt ./... | grep -v -E  "ovsnl.*test|ovsnl/internal/ovsh" )
+GOFMT=$(gofmt -l .)
 
-if [[ ! -z $GOFMT ]]; then
+if [[ -n $GOFMT ]]; then
 	echo -e "Files that are not gofmt'd:\n"
 	echo "$GOFMT"
-	EXIT=1
+	exit 1
 fi
-
-exit $EXIT