Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production ready? #1

Open
guanzo opened this issue Dec 1, 2017 · 2 comments
Open

Production ready? #1

guanzo opened this issue Dec 1, 2017 · 2 comments

Comments

@guanzo
Copy link

guanzo commented Dec 1, 2017

First off, thanks so much for making this.

I love vue's single file components, it just makes sense. I'm brand new to React, and after some googling, it turns out that React recommends CSS in JS, which makes me want to puke. Not only are we going back to inline styles, but I'd have to put styling right next to component logic, camel case everything, etc.

/rant

Anyways, how do you feel about using this in production? Is it stable?

Side note: Vue-loader allows you to inject a scss file into every <style></style>, so you don't have to import variables, mixins, functions, etc into every component. Does your package allow this?

@MunGell
Copy link
Collaborator

MunGell commented Dec 4, 2017

Hi @guanzo

Thank you for your feedback!
To be honest with you, I can't give a definitive answer to your questions as I haven't had a chance to use this loader in production yet. On the other side, I can't see why it wouldn't be production-ready since it only contains logic to split contents of a file into chunks of code and send them through configured loaders.

On SCSS @import - I believe it should work, will update one of the examples to include this code and check that it works.

@MunGell
Copy link
Collaborator

MunGell commented Dec 10, 2017

Just to add: at the moment the only way to test .one components is through running test runners like karma with headless browsers - similar to Vue components.

This is a limitation at the moment since pure React components could be tested in Node.js environment without launching browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants