Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CSS code #145

Open
JoeyStk opened this issue Sep 14, 2023 · 0 comments · May be fixed by #164
Open

Clean up CSS code #145

JoeyStk opened this issue Sep 14, 2023 · 0 comments · May be fixed by #164
Assignees
@JoeyStk
Labels
clean-up With this issue parts of the code are requested to be cleaned
Milestone
Backlog

Comments

@JoeyStk
Copy link
Collaborator

JoeyStk commented Sep 14, 2023

Motivation

Our CSS code has gotten a little chaotic and I think it's time to clean it up a bit

User Story

As a developer I want clean code so that I don't have to change the same CSS code in three places

Proposed Solution

  • For the filter chips / tags: create a custom class and give this class to the filter
  • For outline buttons: create a custom class

Alternatives

None

Additional Context

These changes were wished for in some of the PRs but then postponed

Screenshots
@JoeyStk JoeyStk added the clean-up With this issue parts of the code are requested to be cleaned label Sep 14, 2023
@JoeyStk JoeyStk added this to the Backlog milestone Sep 14, 2023
@JoeyStk JoeyStk self-assigned this Sep 20, 2023
@JoeyStk JoeyStk linked a pull request Sep 25, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoeyStk JoeyStk

Labels
clean-up With this issue parts of the code are requested to be cleaned
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Clean up CSS styling digitalfabrik/integreat-compass
1 participant
@JoeyStk