From f883caf2a4284579174159b392f872e80b8ae6b2 Mon Sep 17 00:00:00 2001 From: Steffen Kleinle Date: Tue, 6 Jul 2021 00:22:35 +0200 Subject: [PATCH 1/5] IGAPP-699: Prevent webview from crashing the whole app --- native/src/App.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/native/src/App.tsx b/native/src/App.tsx index 94c909176b..8c66790f9c 100644 --- a/native/src/App.tsx +++ b/native/src/App.tsx @@ -21,9 +21,7 @@ import SnackbarContainer from './components/SnackbarContainer' import NetInfo from '@react-native-community/netinfo' import sendTrackingSignal from './services/sendTrackingSignal' import useSendOfflineJpalSignals from './hooks/useSendOfflineJpalSignals' -import { enableScreens } from 'react-native-screens' -enableScreens(true) NetInfo.configure({ reachabilityUrl: 'https://cms.integreat-app.de/ping' }) From c2dfc4d3f221de22cc8b278de479b18eaec8475c Mon Sep 17 00:00:00 2001 From: Steffen Kleinle Date: Tue, 6 Jul 2021 00:26:21 +0200 Subject: [PATCH 2/5] IGAPP-699: Add release note --- release-notes/unreleased/IGAPP-699-webview-crashing.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 release-notes/unreleased/IGAPP-699-webview-crashing.yml diff --git a/release-notes/unreleased/IGAPP-699-webview-crashing.yml b/release-notes/unreleased/IGAPP-699-webview-crashing.yml new file mode 100644 index 0000000000..4c9c6b24fb --- /dev/null +++ b/release-notes/unreleased/IGAPP-699-webview-crashing.yml @@ -0,0 +1,6 @@ +issue_key: IGAPP-699 +show_in_stores: true +platforms: + - android +en: Frequent app crashes fixed. +de: Häufige Abstürze der App wurden behoben. From a96647237a310110f9ffacb2e4d1cb93a9afa43f Mon Sep 17 00:00:00 2001 From: Steffen Kleinle Date: Tue, 6 Jul 2021 09:45:28 +0200 Subject: [PATCH 3/5] IGAPP-699: Explicitely disable screens --- native/src/App.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/native/src/App.tsx b/native/src/App.tsx index 8c66790f9c..48b1a22c2f 100644 --- a/native/src/App.tsx +++ b/native/src/App.tsx @@ -21,7 +21,9 @@ import SnackbarContainer from './components/SnackbarContainer' import NetInfo from '@react-native-community/netinfo' import sendTrackingSignal from './services/sendTrackingSignal' import useSendOfflineJpalSignals from './hooks/useSendOfflineJpalSignals' +import { enableScreens } from 'react-native-screens' +enableScreens(false) NetInfo.configure({ reachabilityUrl: 'https://cms.integreat-app.de/ping' }) From 572c1b8fd6edfb50b9df6e020db624501f9af95d Mon Sep 17 00:00:00 2001 From: Steffen Kleinle Date: Tue, 6 Jul 2021 09:47:11 +0200 Subject: [PATCH 4/5] IGAPP-699: Adjust release notes --- release-notes/unreleased/IGAPP-699-webview-crashing.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/release-notes/unreleased/IGAPP-699-webview-crashing.yml b/release-notes/unreleased/IGAPP-699-webview-crashing.yml index 4c9c6b24fb..14eed15a13 100644 --- a/release-notes/unreleased/IGAPP-699-webview-crashing.yml +++ b/release-notes/unreleased/IGAPP-699-webview-crashing.yml @@ -2,5 +2,5 @@ issue_key: IGAPP-699 show_in_stores: true platforms: - android -en: Frequent app crashes fixed. -de: Häufige Abstürze der App wurden behoben. +en: Increased app stability. +de: Verbesserung der Stabilität der App. From e3bd8df47ef954632b3afb8e2cd4a3e65c638df9 Mon Sep 17 00:00:00 2001 From: Steffen Kleinle Date: Tue, 6 Jul 2021 10:28:26 +0200 Subject: [PATCH 5/5] IGAPP-699: Add comment --- native/src/App.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/native/src/App.tsx b/native/src/App.tsx index 48b1a22c2f..4c9b86b8f7 100644 --- a/native/src/App.tsx +++ b/native/src/App.tsx @@ -23,7 +23,9 @@ import sendTrackingSignal from './services/sendTrackingSignal' import useSendOfflineJpalSignals from './hooks/useSendOfflineJpalSignals' import { enableScreens } from 'react-native-screens' +// https://github.com/software-mansion/react-native-screens/issues/105#issuecomment-605369538 enableScreens(false) + NetInfo.configure({ reachabilityUrl: 'https://cms.integreat-app.de/ping' })