Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests //ledger-test-tool/tool:conformance-test-dev-1.dev and //ledger-test-tool/tool:conformance-test-upgrading-dev-1.dev #19506

Open
raphael-speyer-da opened this issue Jul 4, 2024 · 0 comments

Comments

@raphael-speyer-da
Copy link
Collaborator

Many of these tests fail in #19485 because of assertions that the template ID returned from commands matches the template ID in the request. This is no longer always the case, as the request template id may use a package name, whereas the template ids in the results will always use a package id.

In order to unblock merging of package name support in Java codegen, these tests have been disabled, but should be re-enabled by updating all the relevant assertions to match against a template id which uses the appropriate package id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant