Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-merge not working when using with digger apply -p #1872

Open
duy0611 opened this issue Jan 15, 2025 · 1 comment
Open

auto-merge not working when using with digger apply -p #1872

duy0611 opened this issue Jan 15, 2025 · 1 comment

Comments

@duy0611
Copy link

duy0611 commented Jan 15, 2025

I have setup my digger with Orchectrator backend and auto_merge: true. When issuing digger apply with -p flag, the PR is merged immediately when digger apply completes even though not all the impacted projects are applied.

Reading in the code, it seems the case has only be addressed in backendless mode (purely with cli), in which we do check if all the impacted projects have been applied before merging the PR. But it is not in case of Orchestrator backend, in which we check only if all the newly created jobs associated with the created batch have been applied successfully.

Reproduce:

  • Setup Digger with backend mode
  • Add auto_merge: true to digger.yaml file
  • Create example repo with at least 2 impacted projects
  • Create PR and run digger apply with -p flag

Expected result:

  • The mentioned project should be applied successfully, but the PR should not merge yet because not all the impacted projects have been applied

Actual result:

  • The PR is merged and other impacted projects are not yet applied

Fix:

@motatoes
Copy link
Contributor

thanks for the report and the fix, I will review it as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants