Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other Scala versions #579

Closed
hnoson opened this issue May 18, 2020 · 3 comments
Closed

Support for other Scala versions #579

hnoson opened this issue May 18, 2020 · 3 comments

Comments

@hnoson
Copy link

hnoson commented May 18, 2020

Currently, only Scala 2.11 is supported. It's better to have a parameter to specify the version from config file.

static final String MAVEN_COORDINATE_PRE_2_0 = "com.geirsson:scalafmt-core_2.11:";
static final String MAVEN_COORDINATE = "org.scalameta:scalafmt-core_2.11:";

@nedtwigg
Copy link
Member

Would be happy to merge and release a PR for this!

Besides the place you pointed out, the other affected locations are:

ScalaFmtStep probably needs to add a versionScala parameter, and ideally that could be autopopulated by the gradle and maven plugins by slurping it from the build context, but it's alright if that's not possible.

@hnoson
Copy link
Author

hnoson commented May 19, 2020

I realized that the version doesn't matter as long as it's used from Java because the version suffix is for binary compatibility. The formatting functionality doesn't change depending on the Scala version. Please close this issue if there is no concern.

@nedtwigg
Copy link
Member

Thanks, useful to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants