Skip to content

[CI] Port CMake Codecov job from Codebuild to Github Actions. #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2021
Merged

[CI] Port CMake Codecov job from Codebuild to Github Actions. #5809

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e18a11
Port CMake Codecov job from Codebuild to Github Actions.
NlightNFotis Feb 9, 2021
892af6b
Remove codebuild codecov jobs.
NlightNFotis Feb 10, 2021
f02904e
Fix issue with coverage targets not being listed as dependencies
NlightNFotis Feb 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR
"$<TARGET_FILE:jbmc>"
"$<TARGET_FILE:jdiff>"
"$<TARGET_FILE:smt2_solver>"
"$<TARGET_FILE:symtab2gb>"
Copy link
Contributor

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW all this "$<TARGET_FILE:` stuff in here isn't invalid per se, but it also doesn't help. Just listing the target names here would work just as well and look less confusing.

Copy link
Collaborator

@tautschnig tautschnig Feb 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannes-steffenhagen-diffblue Would it be worth doing a cleanup across the code base? Would you mind driving this as my CMake expertise is, well, not really existent?

"libour_archive.a"
WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
)
endif()
Expand Down