Skip to content

Conversation

@tautschnig
Copy link
Collaborator

It was deprecated in 2019 and had no in-tree users left.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

It was deprecated in 2019 and had no in-tree users left.
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5560 (0f6dd4a) into develop (ff1e81e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5560   +/-   ##
========================================
  Coverage    69.01%   69.01%           
========================================
  Files         1187     1187           
  Lines        98257    98253    -4     
========================================
  Hits         67809    67809           
+ Misses       30448    30444    -4     
Flag Coverage Δ
cproversmt2 43.09% <ø> (+<0.01%) ⬆️
regression 66.21% <ø> (+<0.01%) ⬆️
unit 32.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/find_symbols.cpp 84.70% <ø> (+3.80%) ⬆️
src/util/find_symbols.h 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1e81e...0f6dd4a. Read the comment docs.

@tautschnig tautschnig merged commit 309659f into diffblue:develop Nov 11, 2020
@tautschnig tautschnig deleted the remove-deprecated-find_symbols branch November 11, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants