goto-instrument: Remove inline asm before doing various operations

If mutations such as expanding function pointers have been performed, then
removing inline asm is reasonable as well.

Author: tautschnig

src/goto-instrument/goto_instrument_parse_options.cpp

@@ -846,6 +846,11 @@ void goto_instrument_parse_optionst::do_indirect_call_and_rtti_removal(
   remove_exceptions(goto_model);
   status() << "Java instanceof removal" << eom;
   remove_instanceof(goto_model);
+  status() << "Cleaning inline assembler statements" << eom;
+  remove_asm(goto_model);
+
+  goto_model.goto_functions.update();
+  goto_model.goto_functions.compute_loop_numbers();
 }
 
 /// Remove function pointers that can be resolved by analysing const variables
@@ -1221,12 +1226,6 @@ void goto_instrument_parse_optionst::instrument_goto_program()
 
     if(cmdline.isset("mm"))
     {
-      // TODO: move to wmm/weak_mem, and copy goto_functions AFTER some of the
-      // modifications. Do the analysis on the copy, after remove_asm, and
-      // instrument the original (without remove_asm)
-      remove_asm(goto_model);
-      goto_model.goto_functions.update();
-
       std::string mm=cmdline.get_value("mm");
       memory_modelt model;