Replace built-in checks by is_built_in

Author: peterschrammel

src/cbmc/symex_coverage.cpp

@@ -318,7 +318,7 @@ void symex_coveraget::compute_overall_coverage(
       it!=file_records.end();
       ++it)
   {
-    if(has_prefix(id2string(it->first), "<builtin-"))
+    if(source_locationt::is_built_in(id2string(it->first)))
       continue;
 
     const coverage_recordt &f_cov=it->second;

src/goto-instrument/count_eloc.cpp

@@ -44,7 +44,7 @@ static void collect_eloc(
       const irep_idt &file=it->source_location.get_file();
 
       if(!file.empty() &&
-         !has_prefix(id2string(file), "<built-in-"))
+         !it->source_location.is_built_in())
         files[file].insert(it->source_location.get_line());
     }
   }

src/goto-instrument/cover.cpp

@@ -1082,9 +1082,7 @@ void instrument_cover_goals(
 
   // ignore if built-in library
   if(!goto_program.instructions.empty() &&
-     has_prefix(
-       id2string(goto_program.instructions.front().source_location.get_file()),
-       "<builtin-library-"))
+     goto_program.instructions.front().source_location.is_built_in())
     return;
 
   const irep_idt coverage_criterion=as_string(criterion);

src/goto-programs/graphml_witness.cpp

@@ -196,7 +196,7 @@ void graphml_witnesst::operator()(const goto_tracet &goto_trace)
        (it->is_goto() && it->pc->guard.is_true()) ||
        source_location.is_nil() ||
        source_location.get_file().empty() ||
-       source_location.get_file()=="<built-in-additions>" ||
+       source_location.is_built_in() ||
        source_location.get_line().empty())
     {
       step_to_node[it->step_nr]=sink;
@@ -392,7 +392,7 @@ void graphml_witnesst::operator()(const symex_target_equationt &equation)
        (!it->is_assignment() && !it->is_goto() && !it->is_assert()) ||
        (it->is_goto() && it->source.pc->guard.is_true()) ||
        source_location.is_nil() ||
-       source_location.get_file()=="<built-in-additions>" ||
+       source_location.is_built_in() ||
        source_location.get_line().empty())
     {
       step_to_node[step_nr]=sink;