s/const auto/const auto &/ in loops

This was inefficient but now causes build failures on OS X
as it uses -Werror -Wrange-loop-analysis

Author: martin

src/analyses/variable-sensitivity/abstract_enviroment.cpp

@@ -474,7 +474,7 @@ abstract_environmentt::modified_symbols(
   first.map.get_view(view);
   for(const auto &entry : view)
   {
-    const auto second_entry = second.map.find(entry.first);
+    const auto &second_entry = second.map.find(entry.first);
     if(second_entry.has_value())
     {
       if(second_entry.value().get()->has_been_modified(entry.second))

src/analyses/variable-sensitivity/data_dependency_context.cpp

@@ -318,7 +318,7 @@ std::set<goto_programt::const_targett>
 data_dependency_contextt::get_data_dependencies() const
 {
   std::set<goto_programt::const_targett> result;
-  for(const auto d : data_deps)
+  for(const auto &d : data_deps)
     result.insert(d);
   return result;
 }
@@ -332,7 +332,7 @@ std::set<goto_programt::const_targett>
 data_dependency_contextt::get_data_dominators() const
 {
   std::set<goto_programt::const_targett> result;
-  for(const auto d : data_dominators)
+  for(const auto &d : data_dominators)
     result.insert(d);
   return result;
 }

src/analyses/variable-sensitivity/full_struct_abstract_object.cpp

@@ -213,7 +213,7 @@ void full_struct_abstract_objectt::output(
   bool first = true;
 
   out << "{";
-  for(const auto field : type_decl.components())
+  for(const auto &field : type_decl.components())
   {
     auto value = map.find(field.get_name());
     if(value.has_value())

src/analyses/variable-sensitivity/variable_sensitivity_dependence_graph.cpp

@@ -34,7 +34,7 @@ void variable_sensitivity_dependence_domaint::eval_data_deps(
   {
     // If the expression was able to be eval'ed to something with data
     // dependencies, then that's all we need to gather.
-    for(const auto dep : res->get_data_dependencies())
+    for(const auto &dep : res->get_data_dependencies())
       deps[dep].insert(expr);
   }
   else
@@ -188,7 +188,7 @@ void variable_sensitivity_dependence_domaint::data_dependencies(
   {
     const code_function_callt &call = to_code_function_call(to->code);
     const code_function_callt::argumentst &args = call.arguments();
-    for(const auto arg : args)
+    for(const auto &arg : args)
     {
       eval_data_deps(arg, ns, domain_data_deps);
     }