Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diesel_migrations documentation] brocken link to embed_migrations #2324

Closed
p-alik opened this issue Mar 10, 2020 · 3 comments
Closed

[diesel_migrations documentation] brocken link to embed_migrations #2324

p-alik opened this issue Mar 10, 2020 · 3 comments

Comments

@p-alik
Copy link
Contributor

p-alik commented Mar 10, 2020

//! For more information, consult the [`embed_migrations!`](../macro.embed_migrations.html) macro.

The aforementioned link in markdown produces https://docs.rs/crate/diesel_migrations/macro.embed_migrations.html. See diesel_migrations.

Correct target is https://docs.rs/diesel_migrations/1.4.0/diesel_migrations/macro.embed_migrations.html

@weiznich
Copy link
Member

The problem there is if we change the link as suggested it will break here (and any other place that hosts the documentation). This seems to be a fundamental issue with docs.rs. As we are not maintaining that service I do not see how to fix that.

@p-alik
Copy link
Contributor Author

p-alik commented Mar 10, 2020

rust-lang/docs.rs/issues/204 seems to be issue you mentioned. According to this comment there is no appropriate solution available yet. The only absolute link. Wouldn't it be an option?

@weiznich
Copy link
Member

An absolute link is not an appropriate because that would "break" the link anywhere else that is not docs.rs. (For example on the diesel website.)

Closed because this is not actionable, due to rust-lang/docs.rs#204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants