Skip to content

Fix failed model auto-hide defaults - #3930

Merged
diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.26from
rdself:coder/auto-hide-failed-models-default-off
Jun 15, 2026
Merged

diegosouzapw merged 1 commit into
cheaper-inference:release/v3.8.26from
rdself:coder/auto-hide-failed-models-default-off

Conversation

@rdself

@rdself rdself commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Default the provider model Auto-hide failed models toggle to off.
  • Stop single-model tests from writing hidden model overrides when a test fails.
  • Add tooltip copy clarifying that auto-hide only applies to Test all and can remove models from public catalogs such as /v1/models.
  • Cover the default and single-model failure behavior with a focused hook test.

Root Cause

The provider model visibility UI initialized auto-hide as enabled, and the single-model test path wrote hidden model overrides on any failed test. Hidden overrides are consumed by model catalog generation, so a failed single-model test could remove models from /v1/models even when the user only intended to test one model.

Validation

  • npx vitest run --config vitest.config.ts 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/useModelVisibilityHandlers.test.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/passthroughTestHelpers.test.tsx'
  • npx eslint 'src/app/(dashboard)/dashboard/providers/[id]/components/ModelRow.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/components/PassthroughModelsSection.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/hooks/useModelVisibilityHandlers.ts' 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/useModelVisibilityHandlers.test.tsx'
  • npm run typecheck:core

@rdself
rdself requested a review from diegosouzapw as a code owner June 15, 2026 21:55
Copilot AI review requested due to automatic review settings June 15, 2026 21:55
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@diegosouzapw
diegosouzapw changed the base branch from main to release/v3.8.26 June 15, 2026 22:38
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks, @rdself! 🙏 Making auto-hide opt-in (default off) and stopping single-model-test failures from auto-hiding is the right call — auto-hiding on a transient failure is surprising and destructive, and the old default-on amplified it. The tooltip + i18n make the "Test all" semantics clear (non-transient catalog failures only). vitest green (2/2). Merging into release/v3.8.26. 🚀

Note (not your PR's fault): I found the blocking test:vitest (vitest.mcp.config.ts) include glob src/app/(dashboard)/** doesn't match due to the literal parentheses, so these provider __tests__ run under vitest.config.ts but not the blocking job. Tracking that as a separate infra fix.

@diegosouzapw
diegosouzapw merged commit 15c8df4 into cheaper-inference:release/v3.8.26 Jun 15, 2026
1 check passed
@diegosouzapw diegosouzapw mentioned this pull request Jun 16, 2026
@rdself
rdself deleted the coder/auto-hide-failed-models-default-off branch June 24, 2026 03:25
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants