Repository navigation
Fix failed model auto-hide defaults - #3930
diegosouzapw merged 1 commit into
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks, @rdself! 🙏 Making auto-hide opt-in (default off) and stopping single-model-test failures from auto-hiding is the right call — auto-hiding on a transient failure is surprising and destructive, and the old default-on amplified it. The tooltip + i18n make the "Test all" semantics clear (non-transient catalog failures only). vitest green (2/2). Merging into Note (not your PR's fault): I found the blocking |
15c8df4
into
cheaper-inference:release/v3.8.26
Integrated into release/v3.8.26
Summary
Auto-hide failed modelstoggle to off.Test alland can remove models from public catalogs such as/v1/models.Root Cause
The provider model visibility UI initialized auto-hide as enabled, and the single-model test path wrote hidden model overrides on any failed test. Hidden overrides are consumed by model catalog generation, so a failed single-model test could remove models from
/v1/modelseven when the user only intended to test one model.Validation
npx vitest run --config vitest.config.ts 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/useModelVisibilityHandlers.test.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/passthroughTestHelpers.test.tsx'npx eslint 'src/app/(dashboard)/dashboard/providers/[id]/components/ModelRow.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/components/PassthroughModelsSection.tsx' 'src/app/(dashboard)/dashboard/providers/[id]/hooks/useModelVisibilityHandlers.ts' 'src/app/(dashboard)/dashboard/providers/[id]/__tests__/useModelVisibilityHandlers.test.tsx'npm run typecheck:core