Skip to content

fix: Windows electron release — collect portable exe by pattern #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 2 commits into from
Mar 3, 2026
Merged

fix: Windows electron release — collect portable exe by pattern #190

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e15bcf0
fix: collect portable exe by pattern instead of hardcoded filename
benzntech Mar 3, 2026
b66e2e3
fix: address review — break after first portable exe, remove debug ls
benzntech Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/electron-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,13 @@ jobs:
done
# Windows: also copy portable standalone exe
if [ "${{ matrix.platform }}" = "windows" ]; then
[ -f "OmniRoute.exe" ] && cp OmniRoute.exe ../../release-assets/
for file in *.exe; do
# Skip the NSIS installer (contains "Setup") and blockmap files
case "$file" in *Setup*|*.blockmap) continue ;; esac

@kilo-code-bot kilo-code-bot Bot Mar 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: The *.blockmap pattern only matches files ending exactly with .blockmap. Electron may also generate files with extensions like .blockmap.zip or other variants. Consider using a more comprehensive pattern like *blockmap* if needed.

[ -f "$file" ] && cp "$file" "../../release-assets/OmniRoute.exe"

@kilo-code-bot kilo-code-bot Bot Mar 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: This loop will overwrite OmniRoute.exe with each iteration - only the LAST matching .exe file will remain. If multiple portable .exe files exist, only the last one copied will be preserved.

Consider breaking after the first match or explicitly selecting the correct portable exe.

done
fi
ls -la ../../release-assets/ || true

@kilo-code-bot kilo-code-bot Bot Mar 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: The ls -la command appears to be debug output. Consider removing this line before merging to keep the workflow clean, or ensure it's only run conditionally for debugging.


- name: Upload artifacts
uses: actions/upload-artifact@v4
Expand Down
Loading