Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/app/globals.css
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
--color-bg-primary: #f9f9fb;
--color-bg-subtle: #f0f0f5;
--color-surface: #ffffff;
--color-card: #ffffff;
--color-sidebar: #f5f5fa;
--color-border: rgba(0, 0, 0, 0.08);
--color-text-main: #1a1a2e;
Expand All @@ -61,6 +62,7 @@
--color-bg-primary: #0b0e14;
--color-bg-subtle: #111520;
--color-surface: #161b22;
--color-card: #161b22;
--color-sidebar: #10141e;
--color-border: rgba(255, 255, 255, 0.08);
--color-text-main: #e6e6ef;
Expand Down Expand Up @@ -93,6 +95,7 @@
--color-bg-primary: var(--color-bg-primary);
--color-bg-subtle: var(--color-bg-subtle);
--color-surface: var(--color-surface);
--color-card: var(--color-card);
--color-sidebar: var(--color-sidebar);
--color-border: var(--color-border);
--color-text-main: var(--color-text-main);
Expand Down
6 changes: 3 additions & 3 deletions src/shared/components/ActiveRequestsPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export default function ActiveRequestsPanel() {
}

return (
<div className="rounded-xl border border-border bg-card/70">
<div className="rounded-xl border border-border bg-surface">
<div className="flex items-center justify-between gap-4 border-b border-border px-4 py-3">
<div>
<h3 className="text-sm font-semibold uppercase tracking-wide text-text-main">
Expand Down Expand Up @@ -120,8 +120,8 @@ export default function ActiveRequestsPanel() {
</div>

{selectedRow && (
<div className="fixed inset-0 z-50 flex items-center justify-center bg-black/60 px-4 py-6">
<div className="flex max-h-[85vh] w-full max-w-5xl flex-col overflow-hidden rounded-2xl border border-border bg-card shadow-2xl">
<div className="fixed inset-0 z-50 flex items-center justify-center bg-black/55 px-4 py-6 backdrop-blur-[2px]">
<div className="flex max-h-[85vh] w-full max-w-5xl flex-col overflow-hidden rounded-2xl border border-black/10 bg-surface shadow-[0_24px_80px_rgba(15,23,42,0.24)] dark:border-white/10 dark:shadow-2xl">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The modal styling introduces several arbitrary values and inconsistencies with the application's design system. Using border-black/10 and a custom hardcoded shadow deviates from the theme variables (like border-border and --shadow-elevated) and other modals in the app (e.g., AuditLogTab.tsx). This makes the UI less consistent and harder to maintain if theme colors are updated. Additionally, the custom shadow is only applied in light mode, creating a different sense of depth compared to the shadow-2xl used in dark mode. Consider using standard Tailwind scales and theme-aware variables to ensure a unified design language.

Suggested change
<div className="fixed inset-0 z-50 flex items-center justify-center bg-black/55 px-4 py-6 backdrop-blur-[2px]">
<div className="flex max-h-[85vh] w-full max-w-5xl flex-col overflow-hidden rounded-2xl border border-black/10 bg-surface shadow-[0_24px_80px_rgba(15,23,42,0.24)] dark:border-white/10 dark:shadow-2xl">
<div className="fixed inset-0 z-50 flex items-center justify-center bg-black/55 px-4 py-6 backdrop-blur-sm">
<div className="flex max-h-[85vh] w-full max-w-5xl flex-col overflow-hidden rounded-2xl border border-border bg-surface shadow-2xl">

<div className="flex items-start justify-between gap-4 border-b border-border px-5 py-4">
<div>
<h4 className="text-lg font-semibold text-text-main">
Expand Down
15 changes: 15 additions & 0 deletions tests/integration/integration-wiring.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,21 @@ describe("API Routes — dashboard and tool consumers", () => {
assertRouteMethods("src/app/api/usage/call-logs/[id]/route.ts", ["GET"]);
});

it("keeps the active request payload modal on opaque theme surfaces", () => {
const activeRequests = readProjectFile("src/shared/components/ActiveRequestsPanel.tsx");
const globals = readProjectFile("src/app/globals.css");

assert.ok(activeRequests, "ActiveRequestsPanel should exist");
assert.ok(globals, "globals.css should exist");
assert.match(globals, /--color-card:\s+#ffffff/);
assert.match(globals, /--color-card:\s+#161b22/);
assert.match(globals, /--color-card:\s+var\(--color-card\)/);
assert.match(activeRequests, /rounded-xl border border-border bg-surface/);
assert.match(activeRequests, /rounded-2xl[^"]*bg-surface/);
assert.doesNotMatch(activeRequests, /bg-card\/70/);
assert.doesNotMatch(activeRequests, /rounded-2xl[^"]*bg-card/);
});

it("keeps usage quota wired through A2A and MCP tools", () => {
const quotaSkill = readProjectFile("src/lib/a2a/skills/quotaManagement.ts");
const mcpAdvancedTools = readProjectFile("open-sse/mcp-server/tools/advancedTools.ts");
Expand Down