From 10e1c4d7bba0eeed878e764ac11cea5af624a0fc Mon Sep 17 00:00:00 2001 From: Minxi Hou Date: Sat, 3 Oct 2026 11:22:22 -0400 Subject: [PATCH 1/2] fix(combo): type the custom-model row in the auto pool check typecheck:noimplicit:core failed on the callback in expandAutoComboCandidatePool. getCustomModels returns JSON.parse, so the row has no inferred type. The callback only reads id, and a missing id is skipped. The annotation matches that read. Related to #15437. Signed-off-by: Minxi Hou --- open-sse/services/combo/autoStrategy.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/open-sse/services/combo/autoStrategy.ts b/open-sse/services/combo/autoStrategy.ts index 4db43b580dcf..b12e0c8f6251 100644 --- a/open-sse/services/combo/autoStrategy.ts +++ b/open-sse/services/combo/autoStrategy.ts @@ -516,7 +516,8 @@ export async function expandAutoComboCandidatePool( // A provider whose custom rows are all non-chat still has user models, so it // must not fall back to its static chat catalog. const hasUserModels = - userVisibleIds.size > 0 || customModels.some((m) => m.id && !hiddenModels?.has(m.id)); + userVisibleIds.size > 0 || + customModels.some((m: { id?: string }) => m.id && !hiddenModels?.has(m.id)); const expandIds = hasUserModels ? Array.from(userVisibleIds) : getProviderModels(providerId).map((m) => m.id); From 9b7859bdad4e51f6497be65b447adcbe1b1be6d1 Mon Sep 17 00:00:00 2001 From: Minxi Hou Date: Sat, 3 Oct 2026 11:25:37 -0400 Subject: [PATCH 2/2] docs(changelog): add the fragment for the auto pool type fix The type annotation PR needs its own changelog fragment so release aggregation picks it up. Signed-off-by: Minxi Hou --- changelog.d/fixes/15461-auto-pool-custom-model-type.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/fixes/15461-auto-pool-custom-model-type.md diff --git a/changelog.d/fixes/15461-auto-pool-custom-model-type.md b/changelog.d/fixes/15461-auto-pool-custom-model-type.md new file mode 100644 index 000000000000..4297944be727 --- /dev/null +++ b/changelog.d/fixes/15461-auto-pool-custom-model-type.md @@ -0,0 +1 @@ +- **fix(combo):** the auto combo pool check types the custom-model row so `typecheck:noimplicit:core` passes ([#15461](https://github.com/diegosouzapw/OmniRoute/pull/15461) — thanks @HouMinXi)