From 65397ba30fac252337b7b0f5f102034e97507b4a Mon Sep 17 00:00:00 2001 From: Markus Hartung Date: Fri, 28 Aug 2026 04:41:36 -0300 Subject: [PATCH 1/2] fix(tests): await async getExecutor() in gemini-web-image-retirement test The R0.3 executor-registry refactor (#11220) made getExecutor() async; this new test (#11708) predates that and called it synchronously, producing a TypeError (getExecutor(...).getProvider is not a function) instead of the intended assertion. --- tests/unit/gemini-web-image-retirement.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/gemini-web-image-retirement.test.ts b/tests/unit/gemini-web-image-retirement.test.ts index 1e4e36ded9e..c5b3917c074 100644 --- a/tests/unit/gemini-web-image-retirement.test.ts +++ b/tests/unit/gemini-web-image-retirement.test.ts @@ -111,9 +111,9 @@ test("Gemini Web image-only parser and handler artifacts are retired", () => { ); }); -test("Gemini Web chat and legitimate Gemini image providers remain available", () => { +test("Gemini Web chat and legitimate Gemini image providers remain available", async () => { assert.equal(hasSpecializedExecutor("gemini-web"), true); - assert.equal(getExecutor("gemini-web").getProvider(), "gemini-web"); + assert.equal((await getExecutor("gemini-web")).getProvider(), "gemini-web"); assert.equal(REGISTRY["gemini-web"]?.executor, "gemini-web"); assert.deepEqual( REGISTRY["gemini-web"]?.models.map(({ id }) => id), From f7de9595bbbfcb27a5c445d19b99ce8c65e7abea Mon Sep 17 00:00:00 2001 From: Markus Hartung Date: Fri, 28 Aug 2026 04:41:53 -0300 Subject: [PATCH 2/2] chore(changelog): add fragment for the getExecutor async-drift test fix --- .../fixes/11708-gemini-web-retirement-test-async-getexecutor.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/fixes/11708-gemini-web-retirement-test-async-getexecutor.md diff --git a/changelog.d/fixes/11708-gemini-web-retirement-test-async-getexecutor.md b/changelog.d/fixes/11708-gemini-web-retirement-test-async-getexecutor.md new file mode 100644 index 00000000000..1e471f10843 --- /dev/null +++ b/changelog.d/fixes/11708-gemini-web-retirement-test-async-getexecutor.md @@ -0,0 +1 @@ +- **fix(tests):** the new Gemini Web Images retirement test (#11708) called the now-async `getExecutor()` synchronously, throwing `TypeError: getExecutor(...).getProvider is not a function` instead of asserting Gemini Web chat stays available. Awaited to match the R0.3 executor-registry refactor (#11220).