-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max recursion depth exceeded in lfs.discount.utils #175
Comments
Case 1: Case 2: Also, is this possible to reproduce issue eg. when you create new order that is same as one that has no discount applied? If so then can you provide details of products in this order? |
Case 1: https://github.com/diefenbach/django-lfs/blob/master/lfs/criteria/models.py#L375
Case2: |
In this case it is your code that causes problem as it doesn't seem to happen with original LFS code. Have a look at your traceback to see what causes the infinite recursion. Possibly call to 'get_valid_discounts' |
https://github.com/diefenbach/django-lfs/blob/master/lfs/discounts/utils.py#L10
case 1:
When i pass product to -> if discount.is_valid(request, product) max recursion depth exceeded,
and i tried sys.setrecursionlimit(2000) but no use.
case 2:
In testing server we added 100 orders(with discount) manually, in that 100 orders randomly( up to 30 ) discount doesn't added.
The text was updated successfully, but these errors were encountered: