fix mem leak in pasting name #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
previously approved these changes
Oct 19, 2023
AJenbo
approved these changes
Oct 19, 2023
glebm
reviewed
Oct 20, 2023
| SelheroCatToName(clipboard, UiTextInput, UiTextInputLen); | ||
| if (SDL_HasClipboardText() == SDL_TRUE) { | ||
| char *clipboard = SDL_GetClipboardText(); | ||
| if (clipboard == nullptr) { |
There was a problem hiding this comment.
On failure, clipboard is not a nullptr but an empty string, so this check should be:
if (*clipboard == '\0') {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://wiki.libsdl.org/SDL2/SDL_GetClipboardText
Caller must call SDL_free() on the returned pointer when done with it (even if there was an error).
Also added checking if clipboard isn't empty