Xbox: nxdk does not support hypot()

[Toddimyre]

Operating System

Other (please specify)

DevilutionX version

1.5.1

Describe

OS: Xbox

I came across a hard crash upon entering floor / level 1 and attempting to open a sarcophagus. I grabbed a screenshot of the crash with its error info. It can be viewed here:

To Reproduce

I'm not sure if it can be reproduced easily, as I turned off the Xbox for the evening. But, I did the following:

1. Selected my warrior.
2. Sold the starting club.
3. Accepted the butcher quest.
4. Entered the cathedral.
5. Walked southwest a bit.
6. Attempted to open a sarcophagus as a fallen one got close enough to pop the health bar.

Expected Behavior

I had hoped some awesome goodies would've appeared from the sarcophagus.

[AJenbo]

The issue here appears to be that nxdk does not actually implement this function:
https://github.com/XboxDev/nxdk-pdclib/blob/nxdk/platform/xbox/functions/math/hypot.c

The issue so should be reported with them, but they are probably also aware of the defect. I have created a PR for them to consider, so hopefully this can be solved in a not to fare in to the future version of nxdk.

[qndel]

@Toddimyre why would you upload the pic on some 3rd party website instead of on github directly?

[JayFoxRox]

but they are probably also aware of the defect

The maintainers are aware that the nxdk libc is rather incomplete in general 😛

However, at least I wasn't aware that this function even existed in the C standard, so I didn't even know it was a low-hanging fruit (I always implemented this myself, despite hypot leaving more room for compiler optimizations.. probably).

Thanks for reporting and sending the PR 👍

[AJenbo]

@glebm do you know if we are building nxdk in debug mode since we have asserts like this?

[glebm]

@AJenbo Don't know but here is how we're building it:

devilutionX/.github/workflows/xbox_nxdk.yml

Line 41 in 8b141d9

run: PATH="${NXDK_DIR}/bin:$PATH" make -j $(nproc) -C "$NXDK_DIR" NXDK_ONLY=1 all cxbe

[glebm]

@AJenbo Yes we are!
https://github.com/XboxDev/nxdk/blob/ed21e83da43b8b8da14a9a78cf2528d9b5df86a7/.github/workflows/build_docker_image.yml#L14-L23

[glebm]

Fixed in #6761 by avoiding hypot

[Toddimyre]

@Toddimyre why would you upload the pic on some 3rd party website instead of on github directly?

My apologies for the delay. But to answer your question, I don't use GitHub very often, so I was unaware that was even and option. And I used Google Photos as the upload location because my device automatically uploads photos there anyway. It was quick and painless to create a link.

[glebm]

Version 1.5.2 is now out with a fix for this issue!