Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories are not being created on Android devices #688

Closed
josheb opened this issue Dec 23, 2021 · 2 comments
Closed

Directories are not being created on Android devices #688

josheb opened this issue Dec 23, 2021 · 2 comments
Labels
Bug 🐞 Something isn't working

Comments

@josheb
Copy link

josheb commented Dec 23, 2021

The directory structure for dialogic and saves is not being created when running a godot application with dialogic on android.

To Reproduce
Steps to reproduce the behavior:

  1. Call Dialogic.save('slot1')
  2. Look for saves with Dialogic.get_slot_names()
  3. Observe '[D] Error: failed to access working directory' from adb logcat output

Expected behavior
Saves should write just as they do on PC platforms

System:

  • OS: Android 11
  • Godot Version: 3.4.2
  • Dialogic Version: 1.3

Solutions

Possible fixes

I edited Other/DialogicResources.gd functions get_saves_folders() and add_save_folder() to include the following:

if not directory.dir_exists(WORKING_DIR):
    if not directory.make_dir(WORKING_DIR):
        print("[D] Error: Failed to create working directory.")

After making this change the save slots work as expected.

@Jowan-Spooner Jowan-Spooner added the Bug 🐞 Something isn't working label Dec 29, 2021
@coppolaemilio coppolaemilio added this to the Version 1.4.3 milestone Jun 18, 2022
@WolfgangSenff
Copy link

This should be fixed by #1801 and can be closed. (Thought that automatically happened with Github, not sure why it's not.)

@Jowan-Spooner
Copy link
Member

I guess because this wasn't merged into main but the dialogic 1 branch. I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working
Development

No branches or pull requests

4 participants