Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo local-registry --sync Cargo.lock vendor/ fails when .cargo/config is present #79

Closed
idubrov opened this issue Dec 14, 2018 · 2 comments · Fixed by #80
Closed

cargo local-registry --sync Cargo.lock vendor/ fails when .cargo/config is present #79

idubrov opened this issue Dec 14, 2018 · 2 comments · Fixed by #80

Comments

@idubrov
Copy link
Contributor

idubrov commented Dec 14, 2018

cargo local-registry --sync Cargo.lock vendor/ fails when .cargo/config overriding the crates-io is present:

[source.crates-io]
registry = 'https://github.com/rust-lang/crates.io-index'
replace-with = 'local-registry'

[source.local-registry]
local-registry = "vendor"

Potentially, something similar to this code in cargo-vendor is needed?

@gilescope
Copy link

That fix works nicely unless except we need the source replacement to actually talk to crates.io (Our proxy blocks it as it doesn't end in '.git' like all the other gitlab repos do.)

Maybe we need to make this ignore either smarter or just configurable?

@ChrisGreenaway
Copy link
Collaborator

@gilescope - would you create a new issue with a little more detail rather than commenting on an old, closed issue please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants