fix(radio): modal jumping when clicking radio #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Birkbjo
changed the title
Birkbjo
force-pushed
the
dhis2-9104/fix-modal-jump-when-element-select
branch
from
ffd9cb6
to
9d3fc96
Compare
Mohammer5
approved these changes
Aug 11, 2020
|
We are using the input to handle focus, so |
Birkbjo
force-pushed
the
dhis2-9104/fix-modal-jump-when-element-select
branch
from
e70e724
to
c8a2671
Compare
|
🎉 This PR is included in version 5.4.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Jira issue with link to codesandbox: https://jira.dhis2.org/browse/DHIS2-9104
When clicking a radio in a modal that is scrollable, the modal will scroll and the content will be outside of the viewport. This is due to how the modal is scrolling the modal-content only, using
display: flex. I believe the reason for using flex here is to keep the header above the content when scrolling.The Card rendered by the Modal will have a height of something like 2x of the modal-content. So when a Radio is clicked, the page is for some weird reason (see https://stackoverflow.com/questions/24299567/radio-button-causes-browser-to-jump-to-the-top/24323870) scrolled to the position of the clicked Radio in the
Card-div. As far as I understand this, it's due to theposition: absoluteon the Radios, and the Card being the closest relative-positioned element.This fix makes the label positioned relative, so when a Radio is clicked, it will not scroll to the position. However, this could potentially make absolutely position elements in the modal behave weirdly, so another solution would be to have a simple
display: blockon the Card ( instead of flex) - but that would mean we would scroll the header as well.Maybe the
ModalContentshould haveposition: relativeas well, to play nice with absolutely positioned elements?@Mohammer5 replied that position relative is not ideal. The inputs are already hidden withopacity: 0, and it looks likevisibility: hiddenworks as well. Source for fix in above stackoverflow.