feat(index js): add requiredIf to named exports #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the pre-commit hook, the docs are built. And for this repo that means a new readme is (or rather "should be") generated based on the template If it fails, I don't know if fixing it locally is a good way forward. Perhaps we should just focus on building the docs in travis and making sure it works there. |
Mohammer5
force-pushed
the
RequiredIf_named_export
branch
from
a5be377
to
812cd80
Compare
HendrikThePendric
approved these changes
Nov 21, 2019
dhis2-bot
added a commit
that referenced
this pull request
Nov 21, 2019
# [1.4.0](v1.3.0...v1.4.0) (2019-11-21) ### Features * **index js:** add requiredIf to named exports ([#75](#75)) ([cf6697e](cf6697e))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HendrikThePendric for some reasons, when I commit changes, the pre-commit hook just emptied the README, no idea what went wrong here. So this is something we need to fix, do you have an idea what went wrong (#76)?EDIT: My local deps weren't up2date