Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local offline handling [DHIS2-12937] #2230

Merged
merged 10 commits into from
Mar 14, 2023
Merged

Conversation

KaiVandivier
Copy link
Contributor

@KaiVandivier KaiVandivier commented Mar 3, 2023

Fixes the error in DHIS2-12937

Seems to depend on this PR in the analytics library: dhis2/analytics#1443

Description

  • Switches from useOnlineStatus to useDhis2ConnectionStatus to detect connection to the DHIS2 server instead of the network status

Testing instructions

See the comment on LIBS-315

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Mar 3, 2023

🚀 Deployed on https://pr-2230--dhis2-dashboard.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify March 3, 2023 12:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 3, 2023 12:58 Inactive
@cypress
Copy link

cypress bot commented Mar 3, 2023

36 failed tests on run #3091 ↗︎

36 23 0 0 Flakiness 0

Details:

chore: update @dhis2/analytics for offline support
Project: dashboards-app Commit: f41dcaf25f
Status: Failed Duration: 10:00 💡
Started: Mar 14, 2023 12:51 PM Ended: Mar 14, 2023 1:01 PM
Failed  view_dashboard.feature • 9 failed tests • e2e

View Output Video

Test Artifacts
Viewing dashboards > I switch between dashboards Output Screenshots Video
Viewing dashboards > I search for a dashboard Output Screenshots Video
Viewing dashboards > I search for a dashboard with nonmatching search text Output Screenshots Video
Viewing dashboards > I view the print layout preview Output Screenshots Video
Viewing dashboards > I view the print one-item-per-page preview Output Screenshots Video
Viewing dashboards > I view a dashboard with items lacking shape Output Screenshots Video
Viewing dashboards > I expand the control bar Output Screenshots Video
Viewing dashboards > Maps with tracked entities show layer names in legend Output Screenshots Video
Viewing dashboards > User's preferred dashboard is opened Output Screenshots Video
Failed  item_context_menu.feature • 7 failed tests • e2e

View Output Video

Test Artifacts
Item context menu > View chart as table Output Screenshots Video
Item context menu > View chart as map Output Screenshots Video
Item context menu > View table as chart Output Screenshots Video
Item context menu > Open chart in Data Visualizer app Output Screenshots Video
Item context menu > Open the interpretations panel Output Screenshots Video
Item context menu > Text item does not have a context menu Output Screenshots Video
Item context menu > Chart item has a fullscreen option Output Screenshots Video
Failed  view_errors.feature • 7 failed tests • e2e

View Output Video

Test Artifacts
Errors while in view mode > I navigate to a dashboard that doesn't exist or I don't have access to Output Screenshots Video
Errors while in view mode > I navigate to edit dashboard that doesn't exist Output Screenshots Video
Errors while in view mode > Starring a dashboard fails Output Screenshots Video
Errors while in view mode > View dashboard containing item that is missing type Output Screenshots Video
Errors while in view mode > Item visualization fails when filter applied [DHIS2-11303] Output Screenshots Video
Errors while in view mode > Item visualization fails when filter applied and viewed as table [DHIS2-11303] Output Screenshots Video
Errors while in view mode > Item visualization fails when filter applied and viewed as table then viewed as chart [DHIS2-11303] Output Screenshots Video
Failed  responsive_dashboard.feature • 6 failed tests • e2e

View Output Video

Test Artifacts
Small screen dashboard > I view a dashboard Output Screenshots Video
Small screen dashboard > I am editing an existing dashboard Output Screenshots Video
Small screen dashboard > I am creating a new dashboard Output Screenshots Video
Small screen dashboard > I change the url to edit while in small screen Output Screenshots Video
Small screen dashboard > I cannot edit dashboard filter while in small screen Output Screenshots Video
Small screen dashboard > Edit bar scrolls away in phone landscape Output Screenshots Video
Failed  dashboard_filter.feature • 3 failed tests • e2e

View Output Video

Test Artifacts
Dashboard filter > I add a Period filter Output Screenshots Video
Dashboard filter > I add a Organisation unit filter Output Screenshots Video
Dashboard filter > I add a Facility Type filter Output Screenshots Video

The first 5 failed specs are shown, see all 7 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dhis2-bot dhis2-bot temporarily deployed to netlify March 3, 2023 14:41 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 13, 2023 13:29 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 14, 2023 12:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 14, 2023 13:01 Inactive
@edoardo edoardo merged commit 25ebc58 into master Mar 14, 2023
@edoardo edoardo deleted the DHIS2-12937-fix-local-offline branch March 14, 2023 13:14
dhis2-bot added a commit that referenced this pull request Mar 14, 2023
## [99.10.14](v99.10.13...v99.10.14) (2023-03-14)

### Bug Fixes

* local offline handling [DHIS2-12937] ([#2230](#2230)) ([25ebc58](25ebc58))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 99.10.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

janhenrikoverland pushed a commit that referenced this pull request Mar 17, 2023
* fix: migrate to useDhis2ConnectionStatus

* chore: update @dhis2/analytics for offline support

---------

Co-authored-by: Edoardo Sabadelli <[email protected]>
jenniferarnesen pushed a commit that referenced this pull request Mar 22, 2023
* fix: migrate to useDhis2ConnectionStatus

* chore: update @dhis2/analytics for offline support

---------

Co-authored-by: Edoardo Sabadelli <[email protected]>
jenniferarnesen pushed a commit that referenced this pull request Mar 22, 2023
* fix: migrate to useDhis2ConnectionStatus

* chore: update @dhis2/analytics for offline support

---------

Co-authored-by: Edoardo Sabadelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants