fix: dashboards bar does not resize to 1 row [DHIS2-11097] #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
May 11, 2021
…ashboard-app into fix/cbar-not-resizing-to-one-row
|
🎉 This PR is included in version 31.15.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
jenniferarnesen
added a commit
that referenced
this pull request
May 11, 2021
The function adjustRows is created when the file is first read, meaning that userRows never changes. Moved that functionality to an effect. Backport of this one: #1761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function adjustRows is created when the file is first read, meaning that
userRowsnever changes. Moved that functionality to an effect.Before:
cb.not.resizing.to.1.mov
After
cb.resizes.to.1.row.mov