fix: dashboard filter modal should not be available in small screen #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const filter = { | ||
| id: 'ponies', | ||
| name: 'Ponies', | ||
| values: [{ name: 'Rainbow Dash' }, { name: 'Twilight Sparkle' }], |
There was a problem hiding this comment.
Now I finally know who added all of the my little pony names to DV 🦄 😄
martinkrulltott
approved these changes
Feb 25, 2021
dhis2-bot
added a commit
that referenced
this pull request
Feb 25, 2021
## [31.12.7](v31.12.6...v31.12.7) (2021-02-25) ### Bug Fixes * dashboard filter modal should not be available in small screen ([#1567](#1567)) ([53db918](53db918))
|
🎉 This PR is included in version 31.12.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a separate element in the FilterBadge for small screen that does not have the click action, so that the filter modal cannot be opened while in small screen. (video not included, but the cypress tests covers the scenario)
2 new cypress tests added - one where it is possible to open the filter modal, and one where it isn't possible.
Jest unit test added to check that Filter badge has the correct text on it.