fix: height of interpretations panel in small screen [DHIS2-10425] #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenniferarnesen
changed the title
martinkrulltott
approved these changes
Feb 8, 2021
dhis2-bot
added a commit
that referenced
this pull request
Feb 8, 2021
## [31.10.5](v31.10.4...v31.10.5) (2021-02-08) ### Bug Fixes * calculations for height of interpretations expansion panel in small screen ([#1510](#1510)) ([d2e78c7](d2e78c7))
|
🎉 This PR is included in version 31.10.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: the grid component we use expects item heights expressed as "grid units". The EXPANDED_HEIGHT and EXPANDED_HEIGHT_SM constants are expressed in grid units. That is the amount of height that is added to the item to make room for the interpretations container, which is hardcoded to (now) 334px.
Wide screen and small screen use different grid unit heights (this was to allow more space between items in small screen)
So the fix is to calculate the expanded height of the item correctly, using the correct grid units:
Height of expanded area for wide screen: 17 grid units * 20px = 340px
Height of expanded area for small screen: 13 grid units * 26px = 338px
Meanwhile, the interpretations scroll container has a hardcoded height (now 334px), which will fit in the expanded area of the item for both wide and small screen.
Since a revamp of the interpretations functionality in dashboard is planned (probably using a modal instead of an expanding item), I decided not to refactor of this code (and getting rid of the hardcoded 334px height)
<=480px
greater than 480px
