feat(app-hub): use the app-hub directly #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikarenhill
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Tested it locally against staging app hub and looks like its working fine to me, we need to change that dhis2Version querystring parameter in app hub backend to be "dhis_version" instead as its whats being used here. Or change this querystring to dhis2Version whichever naming convention we'd prefer and which in project to fix it.. Because of that the dhis2 version filter does not work and it will show incompatible versions, but that's really something unrelated to this PR
Added a PR for this here: dhis2/app-hub#244
|
the PR in app-hub for renaming the querystring filter param is now merged |
dhis2-bot
added a commit
that referenced
this pull request
Nov 30, 2020
# [28.2.0](v28.1.4...v28.2.0) (2020-11-30) ### Bug Fixes * **translations:** sync translations from transifex (master) ([9f02cbd](9f02cbd)) * **translations:** sync translations from transifex (master) ([4e66e91](4e66e91)) * **translations:** sync translations from transifex (master) ([70f17c1](70f17c1)) * **translations:** sync translations from transifex (master) ([bc54a78](bc54a78)) * **translations:** sync translations from transifex (master) ([61ea206](61ea206)) * **translations:** sync translations from transifex (master) ([6d665a1](6d665a1)) * **translations:** sync translations from transifex (master) ([1435171](1435171)) * remove deploy-build dep ([83919ff](83919ff)) * update travis.yaml ([60fdc4b](60fdc4b)) * use core AppHub proxy instead of apps.dhis2.org ([#137](#137)) ([#138](#138)) ([3eee6c6](3eee6c6)) * **translations:** sync translations from transifex (master) ([ee159fa](ee159fa)) * **translations:** sync translations from transifex (master) ([7e5574b](7e5574b)) * **translations:** sync translations from transifex (master) ([6e6aee1](6e6aee1)) * add favicon path to avoid 404 error ([8da3f98](8da3f98)) * remove trailing slash on baseUrl before /api ([9065fd5](9065fd5)) * use unversioned endpoint for backwards compat ([358a92a](358a92a)) * **DHIS2-4788:** replaced folderName with key to fix icon URL. ([#38](#38)) ([3ecfa8a](3ecfa8a)) ### Features * support self-updates and label core apps in list ([#122](#122)) ([2868355](2868355)) * **app-hub:** use the app-hub directly ([#88](#88)) ([18d2154](18d2154)) * load apps directly from app store backend ([74192b5](74192b5))
|
🎉 This PR is included in version 28.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: