Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure on macos-latest stack.yaml #2587

Closed
winitzki opened this issue May 12, 2024 · 3 comments
Closed

Build failure on macos-latest stack.yaml #2587

winitzki opened this issue May 12, 2024 · 3 comments

Comments

@winitzki
Copy link
Sponsor Collaborator

The current project fails to build in Github CI for MacOS but succeeds for all other OSes.

See #2586 where there are no changes (other than renaming a dummy type variable).

@winitzki
Copy link
Sponsor Collaborator Author

winitzki commented May 31, 2024

In my view, the root cause is that dhall-haskell cannot build under macos-arm64 due to some dependency problems in hnix-store and/or elsewhere. (When building hnix-store, libsodium of x86 architecture is used instead of arm64. This appears to be a misconfiguration in hnix-store.)

The macos-arm64 build was actually never tested in dhall-haskell, and in fact there were never any macos-arm64 executables released for dhall. When github changed the macos-latest runners to arm64, all builds started failing.

To resolve this issue, I propose the following path forward:

  1. Use macos-13 instead of macos-latest (as in this PR). Change the repo settings so that macos-latest is no longer a requirement for passing the CI builds. (I don't have permissions to do this.) Mention in the README that macos-arm64 is currently unsupported.
  2. Fix the dependency problems so that macos-arm64 build becomes successful. Enable macos-13 and macos-latest builds and publish both dhall-darwin-x86 and dhall-darwin-arm64 executables. Mention in the README that macos-arm64 is now supported.

@winitzki
Copy link
Sponsor Collaborator Author

Build failure was resolved with upgrade to haskell github action version 2.7.

@winitzki
Copy link
Sponsor Collaborator Author

Closing, as the builds are now passing in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant