Refactor image saving with forked process to reduce memory usage, improvements to xpath scraper handling#3099
Merged
Merged
Conversation
…bjects returning a huge amount
dgtlmoon
changed the title
dgtlmoon
changed the title
dgtlmoon
changed the title
This was referenced May 3, 2025
Merged
Merged
Open
This was referenced May 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the only guaranteed way to escape PIL's memory issues is to sub-process it, results were pretty solid after that
Final After 7bb7299 subprocessing the image snapshot chunk builder
Max 218Mb after 300 seconds
At/after 89e4759 after refactoring the xpath_data save from playwright
Max 1Gigabyte after 300 seconds
Current master @ cdfb3f2
Max 870Mb after 300 seconds