Skip to content

Update Apprise to 1.9.1#2876

Merged
dgtlmoon merged 1 commit into
dgtlmoon:masterfrom
wbrawner:patch-1
Jan 2, 2025
Merged

Update Apprise to 1.9.1#2876
dgtlmoon merged 1 commit into
dgtlmoon:masterfrom
wbrawner:patch-1

Conversation

@wbrawner
Copy link
Copy Markdown
Contributor

@wbrawner wbrawner commented Jan 1, 2025

Apprise 1.9.1 includes some fixes for Matrix users particularly in that it allows one to use an access token for authentication instead of logging in for every request, thus avoiding login rate limits.

@dgtlmoon
Copy link
Copy Markdown
Owner

dgtlmoon commented Jan 2, 2025

New version breaks the custom posts:// style integration

2025-01-02 07:59:06,704 - WARNING - An exception occured sending a Custom - post notification.
2025-01-02 07:59:06,704 - DEBUG - <class 'apprise.decorators.base.CustomNotifyPlugin.instantiate_plugin.<locals>.CustomNotifyPluginWrapper'> Exception: cannot import name 'parse_url' from 'apprise.utils' (/usr/local/apprise/utils/__init__.py)

this is why i love tests!

@wbrawner
Copy link
Copy Markdown
Contributor Author

wbrawner commented Jan 2, 2025

I love tests too! Unfortunately I cannot reproduce the test failures locally. I went to take a look at the apprise source, but as far as I can tell, parse_url still exists in apprise.utils: https://github.com/caronc/apprise/blob/master/apprise/utils/parse.py#L525

I'll keep digging to see where things might be going wrong Nevermind, I see what happened. Not sure how it's passing for me locally though...

@wbrawner wbrawner closed this Jan 2, 2025
@wbrawner wbrawner reopened this Jan 2, 2025
@wbrawner
Copy link
Copy Markdown
Contributor Author

wbrawner commented Jan 2, 2025

Not sure why the pull request workflow doesn't seem to be getting triggered again either

@dgtlmoon
Copy link
Copy Markdown
Owner

dgtlmoon commented Jan 2, 2025

Not sure why the pull request workflow doesn't seem to be getting triggered again either

If you are first time contributor it requires me to hit the 'start' button

@dgtlmoon
Copy link
Copy Markdown
Owner

dgtlmoon commented Jan 2, 2025

Something is up with github maybe?

docker pull ghcr.io/linuxserver/baseimage-alpine:3.18

3.18: Pulling from linuxserver/baseimage-alpine
no matching manifest for linux/amd64 in the manifest list entries

but 3.18 is right here.. https://github.com/linuxserver/docker-baseimage-alpine/pkgs/container/baseimage-alpine/329995596?tag=3.18

@dgtlmoon dgtlmoon merged commit 202e47d into dgtlmoon:master Jan 2, 2025
@dgtlmoon
Copy link
Copy Markdown
Owner

dgtlmoon commented Jan 2, 2025

Thanks - looks like a problem over at linuxserver , I'll reach out to them

@wbrawner
Copy link
Copy Markdown
Contributor Author

wbrawner commented Jan 2, 2025

Yeah I was going to say I think it was probably a faulty build on linuxserverio's part. If you compare the images for 3.18 and 3.18-3536ec1a-ls6, you'll see that 3.18 appears to be missing the OS/Arch matrix. It might be a good idea to pin the base image with the SHA included, like so:

FROM ghcr.io/linuxserver/baseimage-alpine@sha256:b136b34558a1a0f4a6f84f14550f9f0daf60b950dab93fd5ed508b775143edba

Obviously the disadvantage is you have to go update that manually but the major advantage is reproducible builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants