Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price detection (once it crosses the "lower" threshold) only works for the first time #2715

Open
lluisd opened this issue Oct 15, 2024 · 2 comments

Comments

@lluisd
Copy link

lluisd commented Oct 15, 2024

Describe the bug
By using price detection with notification I only receive the first time the price is lower as the price that I have set as trigger.

Version
v0.47.03

To Reproduce

Steps to reproduce the behavior:
configuration that I have:
image

notifications that I received from price 310e to 283e which is OK.
image

but future lower prices are not notified, but they appear as detected:
image

here the response of api call of the watcher, where last change timestamp is 1 octuber, the date of the notification:
"restock": { "in_stock": true, "price": 279.89, "currency": "EUR", "original_price": 279.89, "availability": "instock" }, "restock_settings": { "in_stock_processing": "all_changes", "price_change_min": 290.0, "price_change_max": null, "price_change_threshold_percent": 2.0, "follow_price_changes": true }, "history_n": 2, "last_changed": 1727782967,

here the response of the call of the history of the lastest change of the watcher GET /history/latest:
In Stock: True - Price: 283.89

Expected behavior
Have future price detection notification with current price 279.89e

@lluisd lluisd added the triage label Oct 15, 2024
@lluisd lluisd changed the title Stock detection only works for the first time Price detection only works for the first time Oct 15, 2024
@dgtlmoon
Copy link
Owner

and if the price goes ABOVE then back BELOW it will trigger right?

So you're saying - it will not send a new change for every price BELOW the threshold, only once?

@dgtlmoon dgtlmoon changed the title Price detection only works for the first time Price detection (once it crosses the "lower" threshold) only works for the first time Oct 15, 2024
@lluisd
Copy link
Author

lluisd commented Oct 15, 2024

and if the price goes ABOVE then back BELOW it will trigger right?

So you're saying - it will not send a new change for every price BELOW the threshold, only once?

yes, it's what you say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants