fix: determine host ip without ip module

w/ @Brandawg93

api/rtp-utils.ts

@@ -6,6 +6,7 @@ import { map, share, takeUntil } from 'rxjs/operators'
 import getPort from 'get-port'
 import { randomBytes } from 'crypto'
 import { logError } from './util'
+import os from 'os'
 const stun = require('stun'),
   ip = require('ip')
 
@@ -235,3 +236,46 @@ export function generateSrtpOptions(): SrtpOptions {
     srtpSalt: randomBytes(14),
   }
 }
+
+export function getIpAddresses(family = 'ipv4'): Array<string> {
+  const interfaces = os.networkInterfaces(),
+    familyLower = family.toLowerCase()
+
+  return Object.entries(interfaces).reduce(
+    (addresses, [key, interfaceInfos]) => {
+      // Skip all virtual and bridge interfaces
+      if (key.startsWith('v') || key.startsWith('br')) {
+        return addresses
+      }
+
+      const matchingAddresses = (interfaceInfos || []).reduce(
+        (matches, interfaceInfo) => {
+          // Remove addresses that have incorrect family or are internal
+          if (
+            interfaceInfo.internal ||
+            interfaceInfo.family.toLowerCase() !== familyLower
+          ) {
+            return matches
+          }
+
+          return matches.concat([interfaceInfo.address])
+        },
+        [] as string[]
+      )
+
+      return addresses.concat(matchingAddresses)
+    },
+    [] as string[]
+  )
+}
+
+export function getIpAddress(family?: string) {
+  const addresses = getIpAddresses(family),
+    address = addresses[0]
+
+  if (!address) {
+    throw new Error('Unable to detect you IP Address')
+  }
+
+  return address
+}

api/sip-call.ts

@@ -3,12 +3,12 @@ import { logError, logInfo } from './util'
 import {
   createCryptoLine,
   decodeCryptoValue,
+  getIpAddress,
   RtpOptions,
   RtpStreamOptions,
 } from './rtp-utils'
 
-const ip = require('ip'),
-  sip = require('sip'),
+const sip = require('sip'),
   sdp = require('sdp')
 
 export const expiredDingError = new Error('Ding expired, received 480')
@@ -114,7 +114,7 @@ export class SipCall {
   ) {
     const { address, audio, video } = rtpOptions,
       { from } = this.sipOptions,
-      host = ip.address()
+      host = getIpAddress()
 
     this.sipClient = sip.create(
       {

homebridge/camera-source.ts

@@ -2,6 +2,7 @@ import { RingCamera, SipSession } from '../api'
 import { hap } from './hap'
 import {
   createCryptoLine,
+  getIpAddress,
   getSrtpValue,
   getSsrc,
   RtpSplitter,
@@ -28,7 +29,6 @@ import { merge, of, Subject } from 'rxjs'
 import { readFile } from 'fs'
 import { promisify } from 'util'
 
-const ip = require('ip')
 const readFileAsync = promisify(readFile),
   cameraOfflinePath = require.resolve('../../media/camera-offline.jpg'),
   snapshotsBlockedPath = require.resolve('../../media/snapshots-blocked.jpg')
@@ -398,12 +398,8 @@ export class CameraSource implements CameraStreamingDelegate {
         } (${getDurationSeconds(start)}s)`
       )
 
-      const currentAddress = ip.address()
       callback(undefined, {
-        address: {
-          address: currentAddress,
-          type: ip.isV4Format(currentAddress) ? 'v4' : 'v6',
-        },
+        address: getIpAddress(),
         audio: {
           port: returnAudioPort,
           ssrc: audioSsrc,

package.json

@@ -59,7 +59,6 @@
     "ffmpeg-for-homebridge": "0.0.7",
     "get-port": "^5.1.1",
     "got": "^11.5.1",
-    "ip": "1.1.5",
     "node-machine-id": "^1.1.12",
     "public-ip": "4.0.2",
     "rxjs": "^6.6.2",