Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nil *Cache values in Clear and Close #119

Merged
merged 4 commits into from
Jan 14, 2020

Conversation

damz
Copy link
Contributor

@damz damz commented Jan 11, 2020

This change is Reviewable

@claassistantio
Copy link

claassistantio commented Jan 11, 2020

CLA assistant check
All committers have signed the CLA.

@damz
Copy link
Contributor Author

damz commented Jan 11, 2020

Unfortunately CI is broken in this repository, so I had to fix a test that seems to have been broken since at least f823dc4.

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except one small comment. Thanks for the PR @damz 🥇

cache.go Show resolved Hide resolved
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @damz. The Travis build is failing because we've set go 1.12 in go mod and we're trying to build ristretto in go 1.11. I think it should be okay to get rid of go 1.11 from the Travis build.

@martinmr Can you have a look, please?

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @karlmcguire and @manishrjain)

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karlmcguire)

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karlmcguire)

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @karlmcguire)

@jarifibrahim jarifibrahim merged commit fce5e91 into dgraph-io:master Jan 14, 2020
@damz damz deleted the pr/nil-values branch January 14, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants