-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the way metrics are handled for deletions. #111
Conversation
Signed-off-by: balaji <[email protected]>
Signed-off-by: balaji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge. One comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @jarifibrahim)
policy.go, line 294 at r2 (raw file):
p.metrics.add(keyUpdate, key, 1) p.metrics.add(costAdd, key, ^uint64(uint64(prev)-1)) p.metrics.add(costAdd, key, uint64(cost))
Do it in one op.
Signed-off-by: balaji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jarifibrahim)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, 1 of 1 files at r3.
Dismissed @manishrjain from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved
policy.go, line 294 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Do it in one op.
Done by @balajijinnah
This change is