fix(auth): preserve the status code while returning error #7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
approved these changes
May 19, 2021
NamanJain8
added a commit
that referenced
this pull request
May 19, 2021
Clients like dgo rely on GRPC status code for operations in scenarios like relogin if JWT expired. We must preserve the status code while returning and not just wrap it. (cherry picked from commit 1a92da4)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
…) (#7834) * fix(auth): preserve the status code while returning error (#7832) Clients like dgo rely on GRPC status code for operations in scenarios like relogin if JWT expired. We must preserve the status code while returning and not just wrap it. (cherry picked from commit 1a92da4) * nit (cherry picked from commit ce63209)
ahsanbarkati
pushed a commit
that referenced
this pull request
May 27, 2021
…) (#7834) * fix(auth): preserve the status code while returning error (#7832) Clients like dgo rely on GRPC status code for operations in scenarios like relogin if JWT expired. We must preserve the status code while returning and not just wrap it. (cherry picked from commit 1a92da4) * nit (cherry picked from commit ce63209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients like
dgorely on GRPC status code for operations in scenarios like relogin if JWT expired. We must preserve the status code while returning and not just wrap it.This change is