Fix(GraphQL): Fix GraphQL encoding in case of empty list #7726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
abhimanyusinghgaur
approved these changes
Apr 15, 2021
vmrajas
added a commit
that referenced
this pull request
Apr 15, 2021
* Fix output node rewriting in case of null list * Fix lint (cherry picked from commit 9e8ab99)
vmrajas
added a commit
that referenced
this pull request
Apr 16, 2021
OmarAyo
pushed a commit
that referenced
this pull request
May 20, 2021
* Fix output node rewriting in case of null list * Fix lint (cherry picked from commit 9e8ab99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Current GraphQL encoding had a bug which led to timing out in case there is an empty list in dataset and it is queried before any non-null field. This fixes this behaviour.
Fixes DGRAPH-3257
Testing:
This change is