fix: Report Raft heartbeat metrics for Zero v=3 logs and log read index. #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex. (#6538) When logging in v=3, the Zero heartbeat logs would show 0 heartbeats even when the quorum is healthy: RaftComm: [0x1] Heartbeats out: 0, in: 0 This change fixes the reporting for Zero instances by calling ReportRaftComms in Zero: RaftComm: [0x1] Heartbeats out: 28, in: 28 Also, this adds a log for read index to check for healthiness for read index calls. Co-authored-by: Manish R Jain <[email protected]> (cherry picked from commit 241e59a)
parasssh
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #6538.
When logging in v=3, the Zero heartbeat logs would show 0 heartbeats
even when the quorum is healthy:
This change fixes the reporting for Zero instances by calling
ReportRaftComms in Zero:
Also, this adds a log for read index to check for healthiness for read
index calls.
Co-authored-by: Manish R Jain [email protected]
(cherry picked from commit 241e59a)
This change is
Docs Preview: