fix(shutdown): Fix negative waitgroup error #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasssh
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)
Daanikus
reviewed
Sep 24, 2020
| @@ -1089,8 +1089,6 @@ func (g *groupi) askZeroForEE() bool { | |||
| // SubscribeForUpdates will listen for updates for the given group. | |||
| func SubscribeForUpdates(prefixes [][]byte, cb func(kvs *badgerpb.KVList), group uint32, | |||
| closer *z.Closer) { | |||
| defer closer.Done() | |||
There was a problem hiding this comment.
@CodeLingoBot capture z.Closer should only have Done() called once
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2466
We were calling closer.Done() twice.
This change is
Docs Preview: