Alpha Close: Wait for indexing to complete #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
martinmr
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
jarifibrahim
pushed a commit
that referenced
this pull request
Jun 8, 2020
The background reindexing starts indexing in the background but we do not wait for the indexing to complete in case of error while shutting down alpha. This PR fixes that issue by waiting for the background indexing to complete before we shutdown alpha. The issue can be easily seen by adding a long sleep in the background indexing and trying to shutdown alpha. It can be seen that Alpha doesn't wait for the indexing to complete while shutting down. Fixes #3873 (cherry picked from commit dc75424)
jarifibrahim
pushed a commit
that referenced
this pull request
Jun 9, 2020
The background reindexing starts indexing in the background but we do not wait for the indexing to complete in case of error while shutting down alpha. This PR fixes that issue by waiting for the background indexing to complete before we shutdown alpha. The issue can be easily seen by adding a long sleep in the background indexing and trying to shutdown alpha. It can be seen that Alpha doesn't wait for the indexing to complete while shutting down. Fixes #3873 (cherry picked from commit dc75424)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
The background reindexing starts indexing in the background but we do not wait for the indexing to complete in case of error while shutting down alpha. This PR fixes that issue by waiting for the background indexing to complete before we shutdown alpha. The issue can be easily seen by adding a long sleep in the background indexing and trying to shutdown alpha. It can be seen that Alpha doesn't wait for the indexing to complete while shutting down. Fixes hypermodeinc#3873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description.
The background reindexing starts indexing in the background but we do not wait for the indexing to complete while shutting down alpha. This PR fixes that issue by waiting for the background indexing to complete before we shutdown alpha.
The issue can be easily seen by adding a long sleep in the background indexing and trying to shutdown alpha. It can be seen that Alpha doesn't wait for the indexing to complete while shutting down.
GitHub Issue or Jira number.
Partially fixes #3873
See also #3873 (comment)
Affected releases.
v20.03
Changelog tags.
N/A
Please indicate if this is a breaking change.
No
Please indicate if this is an enterprise feature.
No
Please indicate if documentation needs to be updated.
No
Please indicate if end to end testing is needed.
No
This change is