Propose snapshot once indexing is complete #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Mar 23, 2020
mangalaman93
force-pushed
the
aman/snapshot
branch
from
2c6d34e to
1e62027
Compare
manishrjain
approved these changes
Mar 24, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)
worker/mutation.go, line 157 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
Error return value of
gr.Node.proposeSnapshotis not checked (fromerrcheck)
Maybe add a check for time. If it took more than 10s to do the indexing job, then do the proposeSnapshot.
mangalaman93
commented
Mar 25, 2020
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @golangcibot)
worker/mutation.go, line 157 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Maybe add a check for time. If it took more than 10s to do the indexing job, then do the proposeSnapshot.
Done.
mangalaman93
force-pushed
the
aman/snapshot
branch
from
1e62027 to
80f81d3
Compare
danielmai
pushed a commit
that referenced
this pull request
Apr 24, 2020
danielmai
pushed a commit
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is