Do not retrieve facets when max recurse depth has been reached. #3190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, recurse will retrive the facets at max depth, which results in the facets being present in the results while the node on the other side of the edge is absent from the result. This change modifies the logic so that facets are only included if the node to which the edge connects is included in the results as well.
manishrjain
approved these changes
Mar 22, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
…rmodeinc#3190) Currently, recurse will retrive the facets at max depth, which results in the facets being present in the results while the node on the other side of the edge is absent from the result. This change modifies the logic so that facets are only included if the node to which the edge connects is included in the results as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, recurse will retrive the facets at max depth, which results
in the facets being present in the results while the node on the other
side of the edge is absent from the result. This change modifies the
logic so that facets are only included if the node to which the edge
connects is included in the results as well.
Fixes #3163
This change is