-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding changes for 2.0.1 so far #1168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @jarifibrahim, @lgalatin, and @manishrjain)
CHANGELOG.md, line 8 at r1 (raw file):
We should also add the "New APIs" section like the other version CHANGELOG does.
New APIs
CHANGELOG.md, line 26 at r1 (raw file):
ZSTD
It's capitalized as "Zstd".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ashish-goswami, @danielmai, @jarifibrahim, @lgalatin, and @manishrjain)
CHANGELOG.md, line 17 at r2 (raw file):
- WithInMemory (5b6321) - WithZSTDCompressionLevel (3eb4e72)
There are extra spaces here. No big deal.
CHANGELOG.md, line 20 at r2 (raw file):
- Badger.TableInfo - EstimatedSz (f46f8ea)
There are extra spaces here. No big deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ashish-goswami, @danielmai, @jarifibrahim, @lgalatin, and @manishrjain)
This change is