Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding changes for 2.0.1 so far #1168

Merged
merged 2 commits into from
Dec 21, 2019
Merged

Adding changes for 2.0.1 so far #1168

merged 2 commits into from
Dec 21, 2019

Conversation

lgalatin
Copy link
Contributor

@lgalatin lgalatin commented Dec 20, 2019

This change is Reviewable

@claassistantio
Copy link

claassistantio commented Dec 20, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Dec 20, 2019

Coverage Status

Coverage increased (+0.08%) to 69.865% when pulling 83f8913 on lgalatin-patch-1 into ab4352b on master.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, then :lgtm:.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ashish-goswami, @jarifibrahim, @lgalatin, and @manishrjain)


CHANGELOG.md, line 8 at r1 (raw file):
We should also add the "New APIs" section like the other version CHANGELOG does.

New APIs

  • badger
    • ErrGCInMemoryMode (5b6321)
  • Badger.Options
    • WithInMemory (5b6321)
    • WithZSTDCompressionLevel (3eb4e72)
  • Badger.TableInfo

CHANGELOG.md, line 26 at r1 (raw file):

ZSTD

It's capitalized as "Zstd".

@danielmai danielmai changed the title Adding changes for 2.1 so far Adding changes for 2.0.1 so far Dec 20, 2019
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ashish-goswami, @danielmai, @jarifibrahim, @lgalatin, and @manishrjain)


CHANGELOG.md, line 17 at r2 (raw file):

  - WithInMemory (5b6321)
  - WithZSTDCompressionLevel (3eb4e72)
  

There are extra spaces here. No big deal.


CHANGELOG.md, line 20 at r2 (raw file):

- Badger.TableInfo
  - EstimatedSz (f46f8ea)
  

There are extra spaces here. No big deal.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @ashish-goswami, @danielmai, @jarifibrahim, @lgalatin, and @manishrjain)

@lgalatin lgalatin merged commit 8dfdd6d into master Dec 21, 2019
@lgalatin lgalatin deleted the lgalatin-patch-1 branch December 21, 2019 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants