Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still active? #2

Open
ThomasA opened this issue Jul 8, 2016 · 9 comments
Open

Is this project still active? #2

ThomasA opened this issue Jul 8, 2016 · 9 comments

Comments

@ThomasA
Copy link
Collaborator

ThomasA commented Jul 8, 2016

I have some questions I would like to ask about the code.

@dfm
Copy link
Owner

dfm commented Jul 17, 2016

Hi Thomas,

I really just put this together as a proof of concept. I'd be happy to pass it to you if you'd like to take it over!

@ThomasA
Copy link
Collaborator Author

ThomasA commented Jul 17, 2016

Thanks, I can take over if you like.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@marchdf
Copy link
Contributor

marchdf commented Dec 18, 2017

Hi @ThomasA and @dfm, I've been adding to this project, including:

  • 3D interfaces
  • unittest framework for 1D/2D/3D interfaces
  • documentation through Sphinx
  • reorganization of package structure

This is all on my master branch of a fork Thomas's fork of this project. I would like to share this work with the community (through pypi and readthedocs documentation) but it's unclear to me who owns this project. Can someone give me guidance?

@ThomasA
Copy link
Collaborator Author

ThomasA commented Dec 18, 2017

I'll be happy to include it on my fork if you like, but it's up to @dfm what is going to happen to this repo here.

@dfm
Copy link
Owner

dfm commented Dec 19, 2017

Oops! Yes. I'm happy to transfer ownership - sorry that I never responded before!

@fasiha
Copy link

fasiha commented Mar 2, 2018

After running python setup.py install on this repo (or on @marchdf's repo), if I import nufft, I get the following error:

>>> import nufft
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "nufft/__init__.py", line 21, in <module>
    from .nufft import nufft1d1freqs, nufft1d1, nufft1d2, nufft1d3, nufft2d1, nufft2d2, nufft2d3, nufft3d1, nufft3d2, nufft3d3
  File "nufft/nufft.py", line 18, in <module>
    from ._nufft import (
ImportError: No module named _nufft

Am I doing something stupid with Python?

@marchdf
Copy link
Contributor

marchdf commented Mar 2, 2018

I just tried and I am unable to replicate... Things seem to work fine for me (I tried python setup.py install and pip install . . Travis-CI builds are passing for 2.7 and 3.6 so I don't think it's a python version problem. Do you have a fortran compiler and can you see the fortran being compiled?

@fasiha
Copy link

fasiha commented Mar 2, 2018

@marchdf thanks for checking, you're right, all is well—I, an ignoramus, opened Python while in the same directory as python-nufft was cloned into, so Python was trying to import the local directories. When I'm in an application directory, Python imports nufft from site-packages. Sorry and thanks for your hard work!

@marchdf
Copy link
Contributor

marchdf commented Mar 2, 2018

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants