Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Option to switch ros versions for same OS (foxy/galactic, hubble/dasching, rolling) #2

Open
planthaber opened this issue May 22, 2024 · 6 comments

Comments

@planthaber
Copy link
Member

No description provided.

@chhtz
Copy link
Member

chhtz commented Nov 1, 2024

Is there an option to use variables in osdeps-files? Currently ros-2.osdeps-focal and ros-2.osdeps-jammy are almost identical, except for the version strings (which are likely redundant in this case) and the ros-humble- vs ros-jammy- prefixes. (There are a few other differences, but these get lost in the diff)

@chhtz
Copy link
Member

chhtz commented Nov 1, 2024

What would also be convenient, if we could add a custom osdeps-style (similar to gem: or pip:) like:

some_ros_package: ros2: some-ros-package

which then translates to ros-${FLAVOR}-some-ros-package (also allowing FLAVOR=rolling).

If that is not possible, I guess manually constructing everything with ruby is possible?

@planthaber
Copy link
Member Author

The switch currently only allows it on a OS level:

It is organized by the setting an Autoproj.workspace.osdep_suffixes To load the matching file here:

https://github.com/dfki-ric/ros2-package_set/blob/master/init.rb#L9

I think that can easily be changed to ros release names with an question on initial aup with Autoproj.config.declare

For custom ros deb packages, it should be possible to use the suffix files in other packages_sets down the line

@chhtz
Copy link
Member

chhtz commented Nov 4, 2024

Yes, I guess it should be possible to also choose a file based on a different option. I was more asking if it is possible to avoid the redundancy between the ros-2.osdeps-* files (adding another almost identical file for Ubuntu24 at some point would add even more).

@planthaber
Copy link
Member Author

Can you test
#7

Now there are no checked in osdep files for rosdep and ros packages, on autoproj update, they are downloaded (if they don't exist)

@chhtz
Copy link
Member

chhtz commented Nov 4, 2024

Looks good, I'll have a look later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants