Skip to content

Commit 5dac0fb

Browse files
committed
Minor clean-up
1 parent dd74b84 commit 5dac0fb

File tree

8 files changed

+23
-11
lines changed

8 files changed

+23
-11
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,5 +50,5 @@ install:
5050
- ls ${PWD}/tmp/blender/3.2/scripts/addons/phobos
5151

5252
# Finally start our test runner passing it the blender executable from the downloaded blender release
53-
script: python testrunner.py ./tmp/blender/blender
53+
script: python test/testrunner.py ./tmp/blender/blender
5454

README.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://gith
1010
![Phobos](https://github.com/dfki-ric/phobos/wiki/img/phobos_logo_small.png)
1111

1212
Phobos is both a CLI tool and add-on for the open-source 3D modeling software
13-
[Blender](http://www.blender.org) to support your robot model creation and editing
13+
[Blender](http://www.blender.org) to support your robot model creation and editing.
1414

1515
The Blender add-on enables the creation of WYSIWYG robot
1616
models for use in robot frameworks like [ROS](http://wiki.ros.org/) and
@@ -58,6 +58,7 @@ Just zip the `phobos` subfolder: `zip -r phobos.zip phobos` and install it via B
5858
After installation the phobos main menu can be found on the right hand side of the 3D Viewport. If not already visible, one can find a very small arrow to open the Blender toolbar (purple circle showing it in the image).
5959
![Small arrow to open the phobos toolbar widget.](https://github.com/dfki-ric/phobos/wiki/img/blender_phobos_menu_open.png)
6060

61+
Phobos is currently tested and running with Blender v3.2.
6162
### CLI
6263
Just install it using pip:
6364
```bash

codemeta.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"identifier": "",
1313
"codeRepository": "https://github.com/dfki-ric/phobos",
1414
"datePublished": "2019-02-01",
15-
"dateModified": "2020-12-16",
15+
"dateModified": "2022-08-30",
1616
"dateCreated": "2019-02-01",
1717
"description": "Phobos is a python tool for processing simulation models. It comes with a Blender addon to create, edit and annotate robot models in a WYSIWYG environment and a python package/CLI tool to do this automated.",
1818
"keywords": "robotics, Blender, Python, URDF, SDF, model, MARS, SMURF, CLI",

phobos/blender/utils/io.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ def exportModel(model, exportpath='.', entitytypes=None):
559559
export_args = {
560560
"outputdir": exportpath,
561561
"formats": [format for format in entitytypes
562-
if format in ["urdf", "srdf", "sdf"] and getattr(bpy.context.scene, 'export_entity_'+format, False)
562+
if format in ["urdf", "sdf"] and getattr(bpy.context.scene, 'export_entity_'+format, False)
563563
],
564564
"ros_pkg": getattr(getExpSettings(), 'outputPathtype', "relative") == "ros_package",
565565
"ros_pkg_name": None if len(getRosPackageName()) == 0 else getRosPackageName(),

phobos/core/robot.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
from ..utils.transform import create_transformation, inv, get_adjoint
2121
from ..utils.tree import find_close_ancestor_links
2222
from ..utils.urdf import read_urdf_filename, create_pdf_from_urdf, transform_object, get_joint_info_dict
23-
from ..utils.commandline_logging import get_logger
2423

24+
from ..utils.commandline_logging import get_logger
2525
log = get_logger(__name__)
2626

2727

phobos/defs.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
EULER_CONVENTION = 'xyz'
32
RPY_CONVENTION = 'xyz'
43

@@ -68,4 +67,4 @@ def dump_json(obj, **kwargs):
6867
print("YAML not available (backwards compatibility).")
6968

7069
MESH_TYPES = ["dae", "stl", "obj", "mars_obj", "bobj"]
71-
ENTITY_TYPES = ["smurf", "urdf", "sdf", "srdf", "joint_limits", "pdf"]
70+
ENTITY_TYPES = ["smurf", "urdf", "sdf", "joint_limits", "pdf"]

setup.py

+16-4
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,20 @@ def install_requirement(py_exec, package_name, upgrade_pip=False, lib=None):
7171
def check_requirements(py_exec, optional=False, upgrade_pip=False, lib=None):
7272
print("Checking requirements:")
7373
import importlib
74+
requirements = [
75+
"networkx",
76+
"numpy",
77+
"scipy",
78+
"trimesh",
79+
"setuptools",
80+
"collada"
81+
]
82+
optional_requirements = [
83+
"pyyaml",
84+
"pybullet",
85+
"open3d",
86+
"python-fcl"
87+
]
7488
reqs = [requirements]
7589
if optional:
7690
reqs += [optional_requirements]
@@ -107,7 +121,6 @@ def fetch_path_from_blender_script(blender_exec, script, keyword="blender"):
107121

108122

109123
def main(args):
110-
111124
# data
112125
with open("README.md", "r") as fh:
113126
long_description = fh.read()
@@ -123,10 +136,9 @@ def main(args):
123136
kwargs = {
124137
"name": codemeta["title"].lower(), # Replace with your own username
125138
"version": codemeta["version"],
126-
"author":", ".join(codemeta["author"]),
139+
"author": ", ".join(codemeta["author"]),
127140
"author_email": codemeta["maintainer"],
128-
"description": codemeta["description"] + " Revision:" + get_git_branch() + "-"
129-
+ get_git_revision_short_hash(),
141+
"description": codemeta["description"] + " Revision:" + get_git_branch() + "-" + get_git_revision_short_hash(),
130142
"long_description": long_description,
131143
"long_description_content_type":" text/markdown",
132144
"url": codemeta["codeRepository"],

testrunner.py tests/testrunner.py

File renamed without changes.

0 commit comments

Comments
 (0)