From 530227162a3e83228d8fb0f68fde9dbaf0ee915e Mon Sep 17 00:00:00 2001 From: Benjamin Goering Date: Wed, 2 Dec 2020 14:54:03 -0800 Subject: [PATCH 1/2] Clarify in release docs that Firefox Private Browsing wont work and its fine --- docs/process/release.adoc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/process/release.adoc b/docs/process/release.adoc index 918af7a1ce..ec0557ff79 100644 --- a/docs/process/release.adoc +++ b/docs/process/release.adoc @@ -169,9 +169,10 @@ export hello_world_candid_url="http://localhost:8000/candid?canisterId=$($dfx_rc export hello_world_assets_url="http://localhost:8000/?canisterId=$($dfx_rc canister id hello_world_assets)" echo "For the next step, open the following URL in your web browser. Be sure to clear your cache first and/or use 'Private Browsing' mode." +echo "@todo(bengo): Actually don't worry about Firefox Private Browsing until we resolve: https://github.com/dfinity/sdk/issues/1227" # This should print the Asset Canister URL you can use to 'Verify hello_world_assets'. -echo "hello_world_assets_url: Open this in your web browser with empty cache or 'Private Browsing' mode" +echo "hello_world_assets_url: Open this in your web browser with empty cache" echo "$hello_world_assets_url" ---- + @@ -191,7 +192,7 @@ To show the URL, run: [source, bash] ---- # This should print the Candid UI URL you can use to 'Verify hello_world'. -echo "hello_world_candid_url: Open this in your web browser with empty cache or 'Private Browsing' mode" +echo "hello_world_candid_url: Open this in your web browser with empty cache." echo "$hello_world_candid_url" ---- + From 1115bd4f9e24975202e24f76503bc16bc315df2a Mon Sep 17 00:00:00 2001 From: Benjamin Goering Date: Tue, 19 Jan 2021 17:47:10 -0800 Subject: [PATCH 2/2] remove 'bengo' from @todo --- docs/process/release.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/process/release.adoc b/docs/process/release.adoc index ec0557ff79..08702953a3 100644 --- a/docs/process/release.adoc +++ b/docs/process/release.adoc @@ -169,7 +169,7 @@ export hello_world_candid_url="http://localhost:8000/candid?canisterId=$($dfx_rc export hello_world_assets_url="http://localhost:8000/?canisterId=$($dfx_rc canister id hello_world_assets)" echo "For the next step, open the following URL in your web browser. Be sure to clear your cache first and/or use 'Private Browsing' mode." -echo "@todo(bengo): Actually don't worry about Firefox Private Browsing until we resolve: https://github.com/dfinity/sdk/issues/1227" +echo "@todo: Actually don't worry about Firefox Private Browsing until we resolve: https://github.com/dfinity/sdk/issues/1227" # This should print the Asset Canister URL you can use to 'Verify hello_world_assets'. echo "hello_world_assets_url: Open this in your web browser with empty cache"